-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovirt_vm: Check next_run configuration update if exist #47280
Merged
ansibot
merged 1 commit into
ansible:devel
from
machacekondra:ovirt_vm_add_next_run_check
Oct 18, 2018
Merged
ovirt_vm: Check next_run configuration update if exist #47280
ansibot
merged 1 commit into
ansible:devel
from
machacekondra:ovirt_vm_add_next_run_check
Oct 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the update check method so it now check also the next_run configuration of the virtual machine if it exists. So if previously the VM was updated with new parameters, and then reset back, the module didn't set the parameters to be set back in next_run. This PR fixes it so the next run configuration is set back with proper parameters. Signed-off-by: Ondra Machacek <omachace@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894 Signed-off-by: Ondra Machacek <omachace@redhat.com>
66d546a
to
ef3ea6c
Compare
Hi @machacekondra, thank you for submitting this pull-request! |
mwperina
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
shipit |
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
This PR fixes the update check method so it now check also the next_run configuration of the virtual machine if it exists. So if previously the VM was updated with new parameters, and then reset back, the module didn't set the parameters to be set back in next_run. This PR fixes it so the next run configuration is set back with proper parameters. Signed-off-by: Ondra Machacek <omachace@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894 Signed-off-by: Ondra Machacek <omachace@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
automerge
This PR was automatically merged by ansibot.
bug
This issue/PR relates to a bug.
cloud
module
This issue/PR relates to a module.
ovirt
oVirt and RHV community
owner_pr
This PR is made by the module's maintainer.
shipit
This PR is ready to be merged by Core
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes the update check method so it now check also the next_run
configuration of the virtual machine if it exists.
So if previously the VM was updated with new parameters, and then reset
back, the module didn't set the parameters to be set back in next_run.
This PR fixes it so the next run configuration is set back with proper
parameters.
Signed-off-by: Ondra Machacek omachace@redhat.com
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894
ISSUE TYPE
COMPONENT NAME
ovirt_vm
ANSIBLE VERSION
ADDITIONAL INFORMATION